Resolve auto login issue when refreshToken is missing #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve auto login issue when refreshToken is missing
|
Thanks Jim. I will look into this in tick, soon. |
victorskl
approved these changes
Oct 5, 2024
|
Awesome. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Victor,
Firstly, thanks for providing this tool.
I was having this issue mentioned in issue #97.
I read the create-token documentation and if the
grant-typeisrefresh_tokenthenrefreshTokenis required. So I changed the code so that it doesn't attempt to create the token ifrefreshTokenis not found in the cached login.This avoids the KeyError exception.
I have tested this locally by running
make testas well as changing the order of when the refreshToken is tried to before other methods and testing. This worked also.Please let me know if you have any feedback. I didn't bump the release number as I can see you do that in another commit.
I also tried to match your code style as much as possible.
Thanks.